Pádraig Brady <[email protected]> writes: > Also I noticed the reintroduction of NULL in coreutils since: > https://github.com/coreutils/coreutils/commit/1202fac2 > with the referenced (good) justification of https://bugs.gnu.org/66221#53 > The implication of that is, the sc_prohibit_NULL syntax check will fail. > I'll probably remove the syntax check anyway, > and possibly s/nullptr/NULL/ everywhere for consistency.
Removing [email protected] from CC since I'm mostly responding to the part that applies to coreutils. I don't have a strong preference for either NULL or nullptr. Using them inconsistently seems terrible for readability, though. So I would be for s/nullptr/NULL/ or s/NULL/nullptr/ everywhere. Regarding that warning, it seems nice to use if the compatibility issues are fixed. It will help me update GNU time which uses 0 instead of NULL in many places. Collin
