On 25/01/2026 19:27, Collin Funk wrote:
When I wrote this test, I meant to check invalid unicode against
multiple locales/character sets to make sure it didn't affect the
behavior. However, I forgot to export LC_ALL...

-- 8< --

* tests/mktemp/bad-unicode.sh: Run this test case using multiple
locales.
---
  tests/mktemp/bad-unicode.sh | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tests/mktemp/bad-unicode.sh b/tests/mktemp/bad-unicode.sh
index 5838d8659..c010b6373 100755
--- a/tests/mktemp/bad-unicode.sh
+++ b/tests/mktemp/bad-unicode.sh
@@ -24,6 +24,7 @@ echo a > "$(bad_unicode)" \
for loc in C "$LOCALE_FR" "$LOCALE_FR_UTF8"; do
    test -z "$loc" && continue
+  export LC_ALL="$loc"
    # Bad Unicode as a suffix.
    file1=$(mktemp --tmpdir='.' --suffix=$(bad_unicode)) || fail=1
    test -n "$file1" && test -f "$file1" || fail=1

The test still passes on Linux, Solaris, FreeBSD.

So I pushed it.

thanks,
Padraig

Reply via email to