Pádraig Brady <[email protected]> writes:

> On 02/02/2026 19:18, Pádraig Brady wrote:
>> On 02/02/2026 18:40, Collin Funk wrote:
>>> Pádraig Brady <[email protected]> writes:
>>>
>>>> Hrm, even though `export ...` is POSIX supported,
>>>> testing on solaris 11 suggests it may give "Badly formed macro assignment".
>>>> I suspect that's why it was restricted to cfg.mk and thus GNU make.
>>>> I'm thinking perhaps of reverting v9.9-207-g740d33b8d
>>>> so that the post processing / web manual is restricted to GNU make.
>>>> non-gnu make will still work, just without the adjusted anchors.
>>>
>>> If you do that should we add a warning for non-GNU make users when
>>> --enable-manual-url is used?
>>>
>>> I worry about a distribution using local manuals and having their built
>>> programs link to anchors that don't exist because they did not use GNU
>>> make.
>> I suppose.
>> The other option is to propagate MAKEINFO explicitly in gnulib's web-manual 
>> rule,
>> like the following.  Though I'm reluctant to update gnulib again
>> (I'm unsure of the implications of the gettext update for example).
>> diff --git a/top/maint.mk b/top/maint.mk
>> index ad60c8fb11..3475f3733c 100644
>> --- a/top/maint.mk
>> +++ b/top/maint.mk
>> @@ -1740,6 +1740,7 @@ web-manual:
>>           $(AM_V_GEN)test -z "$(manual_title)" \
>>             && { echo define manual_title in cfg.mk 1>&2; exit 1; } || :
>>           $(AM_V_at)cd '$(srcdir)/doc'; \
>> +         MAKEINFO="$(MAKEINFO)" \
>>             $(SHELL) ../$(_build-aux)/gendocs.sh $(gendocs_options_) \
>>                -o '$(abs_builddir)/doc/manual' \
>>                --email $(PACKAGE_BUGREPORT) $(PACKAGE) \
>
> This does seem to work well,
> and we can apply it to coreutils only for now with the attached.

Before viewing the patch I was a bit worried about modifying the files
imported from Gnulib, since many distributions (most? all?) use
./boostrap from a git tag nowadays. Overwriting maint.mk from the
tarball with the unpatched Gnulib one would be unfortunate.

But it looks like you did it the correct way [1].

Nice work,
Collin

[1] https://www.gnu.org/software/gnulib/manual/gnulib.html#Extending-Gnulib-1

Reply via email to