On 08/02/2026 19:57, Collin Funk wrote:
Pádraig Brady <[email protected]> writes:
On 07/02/2026 19:15, Collin Funk wrote:
I wrote this patch last night after noticing that only 'nl -d' needs
changing for multibyte character support. Or am I missing something?
Very nice.
Only two tweaks I can see are:
- a NEWS entry.
- I'd generate exp in the test and not mess with syntax check avoidance, like:
env printf '\n%6s\t%s\n' 1 a 2 b 3 c > exp || framework_failure_
The syntax check change was for existing tests in tests/misc/nl.sh which
I moved in that patch.
This is the section that triggers it:
cat <<\EOF > exp
1 a
1%nb
1 c
1 d
000001 e
===
1^Ia$
$
EOF
I think it will be a bit more difficult to understand if we switch to
'printf'? WDYT?
I attached a v2 patch with a NEWS entry, though.
Collin
Oh right sorry.
syntax check is fine.
thanks,
Padraig
