Pádraig Brady <[email protected]> writes: > On 18/03/2026 06:09, Collin Funk wrote: >> I noticed that 'yes' did not use pipe2_safer to check that the file >> descriptors aren't any of the standard file descriptors. This fixes >> that and some similar cases in other programs. >> Is it worth a NEWS mention? I assume that it is difficult to reach a >> point where pipe or pipe2 would open a standard file descriptor in >> these areas, give that this hasn't been reported as a bug. > > Oh very good spot. > > I did check yes(1) with closed stdout, > with and without the initial probing write(). > But it's best avoid these variances. > > I see we have sc_require_{stdio,stdlib}_safer in cfg.mk. > We probably should have a unistd variant also.
This patch did add that. :) I pushed it. Thanks for the review. Collin
