Bruno Haible <[email protected]> writes:
> Collin Funk wrote:
>> > I thought it would be unproblematic since we check for read errors using
>> > the current working directory in tests/misc/misc/read-errors.sh.
>>
>> Oh, that file has this check that I forgot about:
>>
>> ! cat . >/dev/null 2>&1 || skip_ "Need unreadable directories"
>>
>> I pushed the attached patch after testing it on NetBSD 10.1.
>
> Although the '!' operator does not work correctly on Solaris 10 [1],
> both of these tests pass on Solaris 10:
>
> PASS: tests/misc/read-errors.sh
> PASS: tests/csplit/csplit.sh
Right, I thought it had that limitation but I was not 100% sure. In our
TESTS_ENVIRONMENT we set the SHELL variable like so:
SHELL='$(PREFERABLY_POSIX_SHELL)'
Does the gl_POSIX_SHELL macro in m4/posix-shell.m4 find a better shell
on Solaris 10? The cfarm one is down for maintenance, so sadly I am unable
to test. I do see that we use this feature in various places:
$ git grep -E '^[[:space:]]*(if )?! ' -- '*.sh' | wc -l
45
So I wouldn't be surprised if it was discussed previously and we assumed
Solaris 10 users would already have a nicer shell installed. I would
personally be okay with that, assuming Solaris 10 doesn't have it's EOL
extended yet again.
Collin
