Pádraig Brady <[email protected]> writes: > On 17/08/2026 21:21, Bruno Haible via GNU coreutils General Discussion wrote: >> The new test tests/env/env0-from fails on macOS, says the CI. Here's the log >> file: >> FAIL: tests/env/env0-from >> ========================= >> + printf 'A=file1\0opaque\0\0A=file2\0B=new\0' >> + printf 'A=file2\0opaque\0\0B=new\0' >> + LC_ALL=C >> + sort -z exp >> + env -i A=old src/env --env0-from=mixed -0 >> + LC_ALL=C >> + sort -z all >> + compare exp-sorted out > >> + diff -u exp-sorted out >> Binary files exp-sorted and out differ >> + fail=1 > > I can't repro on cfarm104 (over ssh), > as that setup does not have __CF_USER_TEXT_ENCODING in the environment, > but I'm guessing that's the issue.
I considered modifying tests/init.sh in Gnulib and tests/Coreutils.pm in Coreutils such that 'diff' uses --text if supported. I didn't get around to it since I figured these tests fail fairly infrequently. However, it would have made it so we don't have to guess here. It would also be nice if tests/Coreutils.pm used 'diff -u' instead of 'diff -c'. I assume most of us are far more comfortable reading unified diffs. That file probably was written when coreutils used CVS, so likely not the case at the time. Assuming no one disagrees, I can send a patch for those. Collin
