Pádraig Brady <[email protected]> writes: > Uses of unreachable() should be provably unreachable, and trivially so. > Trivial cases: e.g. after error(NON_ZERO, ...) etc, > or a fully handled switch on enum (proved with -Wswitch-enum).
That makes sense. > Note unreachable() can be defined to exit with -funreachable-traps, > but it's better to use standard build options and distinguish the > different classes of "unreachable" in code. Also clang (22) doesn't > seem to support the -funreachable-traps option. I wanted to mention that previously but forgot the name of that option. I doubt most people running ./configure know (nor should they need to know) about it. The patch looks good to me. Thanks, Collin
