On 19/09/2026 05:23, Collin Funk wrote:
I noticed this spacing in the --help output of 'who' that looked a bit strange:$ who --help Usage: who [OPTION]... [ FILE | ARG1 ARG2 ] Removing the spaces looks better, e.g., like this: $ who --help Usage: who [OPTION]... [FILE | ARG1 ARG2] But I couldn't find any examples of a single argument or multiple arguments combined like that. This looks more like what I expect, but I'm not 100% sure about it, so I haven't pushed: $ who --help Usage: who [OPTION]... [FILE] or: who [OPTION]... [ARG1 ARG2]
Yes it's probably better like this to emphasize you can't combine the "am I" with a file. Though you can on FreeBSD I see. I.e. it supports [ARG1 ARG2] [FILE]. I don't see why we couldn't support that too. I also notice we've no tests for who! I also notice we don't verify file access? (FreeBSD does) $ who /var/log/wtmp.typo; echo $? 0 while we do verify 3 or more args: $ who 1 2 3; echo $? who: extra operand ‘3’ 1 cheers, Padraig
