Pádraig Brady <[email protected]> writes: >> --- a/tests/cp/capability.sh >> +++ b/tests/cp/capability.sh >> @@ -20,6 +20,7 @@ >> print_ver_ cp >> require_root_ >> working_umask_or_skip_ >> +getlimits_ >> grep '^#define HAVE_CAP 1' $CONFIG_HEADER > /dev/null \ >> @@ -51,6 +52,11 @@ EOF >> compare exp err || fail=1 >> test "$ret" = 1 || fail=1 >> returns_ 1 test -f copy1 || fail=1 >> +elif test "$ret" = 1; then >> + cat <<EOF >exp || framework_failure_ >> +cp: setting attributes for 'copy1': $ENOTSUP >> +EOF >> + compare exp err || fail=1 >> else >> compare /dev/null err || fail=1 >> test "$ret" = 0 || fail=1 >> Collin > > Oh right I hadn't checked root only tests. > Yes this is the most appropriate change for this case I think. > I've tested it here and makes the failure pass.
Cool, thanks for the review. I pushed it with a comment describing the rationale, in case that condition needs to be adjusted in the future [1]. Collin [1] https://github.com/coreutils/coreutils/commit/9977a362779d15b64035f9020a22af1b54cd3066
