Re: [PATCH 2/3] maint: move utf8 specific routines to a new utf8 module

[Pádraig Brady]

On 30/09/2026 08:23, Collin Funk wrote:

Pádraig Brady <p...@draigbrady.com> writes:

+#include <uchar.h>
+#include <wchar.h>
+#include <stdint.h>

Is the wchar.h include needed for some reason? I though uchar.h should
cover anything, unless we need functions that operate on wchar_t like in
src/printf.c, but that doesn't seem to be the case here.

I was wondering that myself, but added it for mbszero as uchar.h states:

/* If needed, get btowc, mbstate_t, mbszero, size_t, wctob, wint_t, WEOF.
   Although POSIX allows <uchar.h> to make all symbols visible from <wchar.h>,
   our includers should not rely on this, except they can rely on wint_t and 
WEOF
   when part of the API of a Gnulib module extending <uchar.h> that needs
   these two symbols.  */

Pushed.

cheers,
Padraig