On 24/10/2026 15:41, Mark Wielaard wrote:
splice_cat can leave open file descriptors around. This breaks the valgrind testsuite with --track-fds=yes. This is fairly innocent, like still reachable memory, but does need a new suppression when tracking file descriptor handling. Introduce a new splice_cat_close function that can be used on error from splice_cat and before exiting main.
+ splice_cat_close ();
It's tempting to put this inside "ifdef lint", but give the ubiquity of cat, it probably makes sense to take the small extra cost to cleanup fds. I will add a comment at the last splice_cat_close() call though, as to why we're doing it. I'll apply this now with that tweak. cheers, Padraig
