Pádraig Brady <[email protected]> writes: > On 29/10/2026 04:17, Collin Funk wrote: >> * src/dd.c (main): Also account for seeking bytes in a few conditions. >> * tests/dd/bytes.sh: Add a test case. >> * tests/dd/fail-ftruncate-fstat.sh (fail_ftruncate_fstat): New function. >> Use it to test seeking on bytes, and make sure fstat and ftruncate are >> called. >> * NEWS: Mention the bug fix. > The code changes look good. > I'd adjust the test as per the attached. > > That fixes an obvious typo where $seek_arg wasn't referenced.
Oops. Nice catch. > Also it checks the first invocation actually does inject or skips, > which is a stonger verification than just checking strace supports the args. Thanks. I pushed with those changes. Collin
