Pádraig Brady <[email protected]> writes: >> Assuming I understand correctly, then both changes look good to me. When >> applying the patches using 'git am', though, the commit-msg hook failed >> for me. The first patch failed with: >> # commit-msg: line length (74) greater than than max: 72 >> I fixed it by splitting the command across multiple lines here: >> $ yes $(yes éééááé | head -n9 | paste -s -d，) \ >> | head -n1M > mb.in > > Oh interesting. Can you confirm you have commit v9.0-47-ga2b21e910 installed.
Yep, I do. Strange. >> The second one failed with: >> # commit-msg: invalid first word(s) of summary line: , , >> I fixed it by removing the spaces in the first line of the commit: > > I don't know why my commit hook allowed that. > Perhaps I inadvertently used git commit -n. > >> cut,expand,fold,unexpand: fix handling of multi-byte with short >> reads >> I don't see why either shouldn't be allowed. I'll take a look at the >> hook. > > I wouldn't bother allowing variants there TBH. I prefer the spaces after commas, which are allowed with my most recently sent patch. But I will leave it as is for now. Collin
