Hello, Carsten and Jim, I just sent a pull request to fix some editorials (btw some were already fixed in the git compared to the ietf one), I may have left some of course.
I am happy with the draft, minor comments: - the Base IV has been added to the COSE Key, but is not in the CDDL. Is there a reason or it was simply forgotten? (section 7.1) - I'm not sure what you wanted to say in a sentence in section 11.2, which has some editorial, so I couldn't fix it: "(This practice means if algorithm A is broken and thus can is easier to find, the key derived for algorithm B will not be the same as the key for algorithm B.)" - Same with this sentence in section 12.4.1 "Since the only the math is changed by changing the curve, the curve is not fixed for any of the algorithm identifiers we define." Maybe fixing the editorial will make it more clear, but right now I don't really understand it. - Example C.2.1. is missing the comment for the signature Otherwise, I am satisfied with the draft (including the appendices), thank you for the great work! I appreciated that you introduce the table with the parameters in the beginning of each section. I think it makes it easier to understand at what level those parameters should be used. One question, maybe I missed it or maybe I lack experience: I see you define in section 15. "Application Profiling Considerations" that an application may define new header parameters; what would be the process to register labels for new parameters? Francesca -----Original Message----- From: COSE [mailto:[email protected]] On Behalf Of Carsten Bormann Sent: den 8 juni 2016 18:07 To: Justin Richer <[email protected]> Cc: cose <[email protected]> Subject: Re: [COSE] WGLC Hi Justin, expect my full review by the end of this week (and a pull request for the editorial nits). (Yes, there is a little work to do still, but so far I'm quite happy.) Grüße, Carsten Justin Richer wrote: > Hi everyone, > > Has anybody read the draft? Comments, thoughts, snide remarks? > > — Justin > > _______________________________________________ > COSE mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/cose > > _______________________________________________ COSE mailing list [email protected] https://www.ietf.org/mailman/listinfo/cose _______________________________________________ COSE mailing list [email protected] https://www.ietf.org/mailman/listinfo/cose
