Ben Campbell has entered the following ballot position for draft-ietf-cose-msg-18: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-cose-msg/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- A few minor comments: Substantive: -1.3, definition of "int": Is that really _unsigned_ or negative? Or is it a signed integer than can be negative or non-negative? (contrasting with uint?) (Or is int merely a parent of nint and uint?) -3: What is the scope of uniqueness for map labels? I expected it to be the map, but the text immediately aftewards suggests the scope may be the whole message. Whatever the answer, it would help to be explicit. - Informative References: [I-D.irtf-cfrg-eddsa]: Other algorithm references are normative. Why not this one? Editorial: "Contributing to this Memo" section: Is this intended to stay in the final RFC? If not, it might be worth a note to the RFC editor. -1, first paragraph, last sentence: Comma splice. -1, 2nd paragraph: MAC usually expands to Message Authentication _Code_. -2, 6th paragraph, last sentence: s/method/methods (assuming the following list is a list of methods, and not steps in a method. -3, definition of protected: -4.1, "COSE_Sign_Tagged = #6.991(COSE_Sign) ; Replace 991 with TBD1": Is the comment intended as a note to the RFC editor? If so, it might be helpful to label it as such. -4.3, first bullet: "If multiple items are included, care needs to be taken that data cannot bleed between the items." Is this talking about data framing, or something else? _______________________________________________ COSE mailing list [email protected] https://www.ietf.org/mailman/listinfo/cose
