This is probably not quite ready for detailed comments, but I did look it over pretty carefully. I’ve sent comments to Hannes private, but here’s two that may be of general interest.
Rename encapsulated_key The main CBOR structure being defined here is “encapsulated_key”. I think it should at least have “HPKE” in its name because it clearly is only for HPKE. It will sit in the COSE registry. It’s clearly not any general COSE mechanism for encapsulating keys. Inputs to SealBase in two-layer mode I think an Enc_structure (5.3 in 9052) with context “Enc_Recipient” is what should be given to SealBase for the aad parameter. This is not super clear from 9052, but I think it is right. I’ve also been reading Jim’s code and I think that is what it does. (There’s a few layers and occurrences of AAD here — the external AAD input to COSE, the AAD input to the AEAD and the AAD input to SealBase — none of these are the same). Also, I think the info parameter to SealBase here should be “”. LL > On Feb 27, 2023, at 10:57 AM, Hannes Tschofenig <[email protected]> > wrote: > > Hi all, > > > I have just submitted version -03 of the COSE-HPKE draft capturing the > feedback on the mailing list from the last 6 months: > > https://datatracker.ietf.org/doc/html/draft-ietf-cose-hpke > > > Please let me know if you think that this version is heading into the > right direction. > > > Ciao > > Hannes > > > > > _______________________________________________ > COSE mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/cose
_______________________________________________ COSE mailing list [email protected] https://www.ietf.org/mailman/listinfo/cose
