There is one substantive issue identified below to address in the draft. The rest are editorial.
Section 1 (Introduction): Change "the registry created by [RFC8747<https://www.ietf.org/archive/id/draft-ietf-cose-key-thumbprint-03.html#RFC8747>]" to "the IANA "CWT Confirmation Methods" registry created by [RFC8747<https://www.ietf.org/archive/id/draft-ietf-cose-key-thumbprint-03.html#RFC8747>]". Section 6 (Example): In the text below, the two clauses both say that values are correctly ordered, but the orders are different! Please correct this to use the same correct order in both. The required order based on Section 4.2.1 of [RFC8949<https://www.ietf.org/archive/id/draft-ietf-cose-key-thumbprint-03.html#RFC8949>] is: * "y" (label: -3, data type: bstr) * "x" (label: -2, data type: bstr) * "crv" (label: -1, data type: int) * "kty" (label: 1, data type: int) The resulting COSE Key structure, in CBOR diagnostic format with line-breaks added for better readability, with the minimum parameters in the correct order are. { 1:2, -1:1, -2:h'65eda5a12577c2bae829437fe338701a 10aaa375e1bb5b5de108de439c08551d', -3:h'1e52ed75701163f7f9e40ddf9f341b3d c9ba860af7e0ca7ca7e9eecd0084d19c' } Section 8 (IANA Considerations): Add "IANA" before ""CWT Confirmation Methods" registry". Section 9 (Acknowledgements): Please change "Mike Jones" to "Michael B. Jones". (I use that professionally because there are a whole lot of Mike Joneses out there!) Thanks for writing this specification. -- Mike
_______________________________________________ COSE mailing list [email protected] https://www.ietf.org/mailman/listinfo/cose
