Thanks for the quick response Andrew. I'll make the requested changes, ensure it builds properly and re-submit shortly.
--Jason Andrew Mortensen wrote: > > On Aug 5, 2009, at 12:00 PM, Jason Noble wrote: > >> While recently seting up a Cosign installation, we needed to >> explicitly set the Kerberos principal Cosign uses. The attached >> patch allows the configuration variable "cosignprincipal" in >> cosign.conf to set the principal Cosign will use to authenticate to >> Kerberos as. We thought this may be helpful to other users as well, >> so are giving it to the community. The patch was created against >> v3.0.2. > > This is reasonable. A couple things: > > 1) There's no need to use syslog. Use fprintf to stderr instead, and > Apache will dump the output to its error log. > > 2) Why is the error message commented out if the > krb5_verify_init_creds call fails? This looks like the remnants of > some debugging while you were testing your patch. Adding an fprintf to > log when krb5_verify_init_creds fails is just fine; what you've got > stuck in that block isn't. > > Clean these things up, and I'll commit it. Thanks for supporting cosign! > > andrew ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Cosign-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cosign-discuss
