Hey Guys,
I think some recent changes to authmysql break dash-extensions, at least, that's what we're seeing. 0.45.2.20040325 works; upgrading to 0.45.4.20040502 breaks; mySQL logging shows that only 1 query is ever issued for things like [EMAIL PROTECTED]; as opposed to [EMAIL PROTECTED], [EMAIL PROTECTED] in the former version.
Brian, the changeLog shows some tweaks to authlib/authmysqllib.c on 4/20; is it possible that the "return (0)" lines are breaking something elsewhere that was relying on the final "return &ui" containing data for a recursive search? The following change seems to correct the problem:
In authlib/authmysqllib.c, line 834:
return (&ui);
instead of
return (0); ?I'm not sure of the security implications of this change; I didn't read through the surrounding code in enough detail to make sure this is safe. Can you confirm that this change is safe; and if so, Sam, can this be fixed in the next release?
best, Jeff
Index: authlib/authmysqllib.c
===================================================================
--- authlib/authmysqllib.c Tue Apr 20 21:05:35 2004
+++ authlib/authmysqllib.c Sun May 9 14:33:43 2004
@@ -832,5 +832,5 @@
dprintf("zero rows returned");
mysql_free_result(result);
- return (0);
+ return (&ui);
}
}
Index: ChangeLog
===================================================================
--- ChangeLog Sun May 9 14:51:51 2004
+++ ChangeLog Sun May 9 14:50:52 2004
@@ -1,2 +1,6 @@
+2004-05-09 Jeff Potter <[EMAIL PROTECTED]>
+
+ * authlib/authmysqllib.c: fixed dash-extensions
+
2004-05-01 Brian Candler <[EMAIL PROTECTED]>-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
_______________________________________________
courier-users mailing list
[EMAIL PROTECTED]
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users
