Re: [courier-users] Patch to ignore backup and editor files in makedat

[Sam Varshavchik]

Martijn Lievaart writes:

Sam,



Cheers,
M4


--- makedat     2006-04-20 21:36:39.000000000 +0200
+++ makedat~    2006-03-27 22:26:38.000000000 +0200
@@ -84,7 +84,7 @@
        then
                if test "$srcfile" != "CVS"
                then
-                       for f in `ls "$srcfile"/*|grep -e "~$" -e "^#"`
+                       for f in "$srcfile"/*
                        do
                                test -f $f || continue
                                cat "$f" || return

Please consider for inclusion. I expect no adverse effects (how many people have valid files ending in ~ or starting with #), and it makes life easier on most common setups.

+ Fork an extra child process,

+ Run an expensive grep binary





3) Your patch was also generated backwards.

1) Ugly, depends on GNU grep extensions, and is very inefficient. Although in today's modern age of gigahertz CPUs this does not matter much, I tend to be a perfectionist. This is an example of something that really bothers me, because it is completely unnecessary, to: When the same job can be done by the shell, using the shell's built-in regular expression pattern matching in the case/esac construct. 2) The patch should be done against makedat.in. makedat gets generated from makedat.in

pgpGpURD3ipem.pgp
Description: PGP signature