On 9/24/07, Barbie <[EMAIL PROTECTED]> wrote: > The report therefore isn't a FAIL because it's already told you it needs > a library, it isn't necessarily an UNKNOWN because there is a test suite > and it isn't an NA because it has nothing to do with the Perl or > platform. > > It should, as I've mentioned before, be dropped before the tester sends > the report.
Agreed. > Treat them like you would for a regular dependency that fails. If we > test DISTRO-A and it requires DISTRO-B, we then start to make/test > DISTRO-B. If DISTRO-B fails for any reason we do not send a FAIL report > for DISTRO-A. This is no different, it's just that instead of DISTRO-B > we have LIBRARY-B. I agree in principle. But when DISTRO-B is really LIBRARY-B we have no standard way of telling/checking that the library is available. (Err.. I actually started work on this a while ago and then let it sit... it's called Alien::Probe... maybe I should go dust it off.) > > Better would be a way for a *.PL file to communicate that a library > > prerequisite was missing so we could just discard the report. As much > > as I dislike the "OS unsupported" text parsing approach, maybe we need > > a similar "Required library not installed" error message that we can > > detect. > > Suggesting the "OS Unsupported" is a bad thing, as it will lead to I don't want to suggest "OS Unsupported" -- but I do want to suggest they do this: die "Required library not installed: libfoo\n"; And then I'll have CPAN::Reporter parse for "^Required library not installed" and discard the report if I find that line in the output. Frankly, that's about a 10 minute piece of work for me -- most of which will be creating a test distribution and adding to the proper file. > m/No library found for -l([-\w]+)/g Should I add that to CPAN::Reporter as well? If so, I'll squeak it in before 1.00. How portable is that across compilers? > The only reason I can see for anyone interested in these results would > be someone wanting to know either which Alien-* distribution to work on > next, or wanting to know the most used library in CPAN. Authors and > users already know the score. People are hot on quality/Kwalitee -- now that search.cpan.org shows PASS/FAIL/etc counts, module authors care about the perception of their modules. David
