On Thu, May 9, 2013 at 9:54 AM, Shlomi Fish <shlo...@shlomifish.org> wrote:
> The problem is that newer versions of > libxml2 and libxslt contain some bug fixes, and with older versions without > these bug fixes, the tests fail. > I'm not sure I get this. So, to be taken with appropriate amounts of salt ... How essential are those bug fixes to your modules' functionality? A) If your module doesn't work without those bugfixes, you should require the fixed versions (and not rely on the tests to "catch" this situation). B) If your module does its job just fine even without those bugfixes (lib code doesn't itself trigger any of those bugs), the failing tests are really testing libxml2 and libxslt, not (just) your module. You should probably rewrite those tests so that they (the test code) don't trigger those bugs, or even skip those tests if the libx{ml2,slt} are old. A little from column A, a little from column B? Mix and match to taste. Reduced functionality without those bugfixes? Yeah, that's trickier ... I guess it comes down to whether that functionality is considered essential or optional, and I'd fall back to the A and B cases, with an eye to documentation. Or I'm far out on the wrong field ... Eirik