Thank you Olivier!

Although is not the best solution available, I understand it is in better shape than before (depending on h2ph, which configuration is messy anyway).

I'm considering using Inline::C to figure the value during distribution setup, but for now I'm writing tests to validate your suggestions.

Em 30/04/2017 17:12, Olivier Mengué escreveu:
Hi,

I've implemented my suggestion and submitted a pull request.
https://github.com/glasswalk3r/Linux-NFS-BigDir/pull/1
Maintaining a hardcoded map of archname to syscall number for a single
syscall on a single OS will be much less effort for you than
implementing the other suggestions (XS code...).

Once you make a release with this patch you'll be able to easily see the
missing values of $Config{archname} using the CPAN testers result analysis:
http://analysis.cpantesters.org/?author=ARFREITAS&age=91.3&SUBMIT_xxx=Submit



2017-02-13 11:09 GMT+01:00 Olivier Mengué <olivier.men...@gmail.com
<mailto:olivier.men...@gmail.com>>:

    On a quick look at the code, you seem to use h2ph only to extract
    the Linux syscalls. And the only syscall used in the code is getdents.
    But syscalls numbers are not expected to change from one machine to
    another.
    So using h2ph for this task seems to be just masochism. I would just
    define a numeric constant.

    Olivier.

    2017-02-06 15:34 GMT+01:00 Alceu Rodrigues de Freitas Junior via
    cpan-testers-discuss <cpan-testers-discuss@perl.org
    <mailto:cpan-testers-discuss@perl.org>>:

        Hello folks,

        I just released a new distribution
        (http://search.cpan.org/~arfreitas/Linux-NFS-BigDir-0.001/
        <http://search.cpan.org/~arfreitas/Linux-NFS-BigDir-0.001/>) but
        I see that is getting a lot of fails because h2ph is not configured.

        I'm wondering if there is any recommended way to execute this
        configuration during the distribution setup (or if it is not
        recommended anyway). I'm using Dist::Zilla for it, and see that
        there is this plugin Dist::Zilla::Plugin::Run should be enough
        to execute the steps documented at
        https://github.com/glasswalk3r/Linux-NFS-BigDir#install-receipt
        <https://github.com/glasswalk3r/Linux-NFS-BigDir#install-receipt> (but
        I'm not sure it would work in other Linux distributions).

        Another possibility is to do "require" under eval() block and
        skip all tests if it generates an exception.

        Thanks!

        Alceu



  • adding h2ph con... Alceu Rodrigues de Freitas Junior via cpan-testers-discuss
    • Re: adding... Olivier Mengué
      • Re: ad... Alceu Rodrigues de Freitas Junior via cpan-testers-discuss
      • Re: ad... Olivier Mengué
        • Re... Alceu Rodrigues de Freitas Junior via cpan-testers-discuss
    • Re: adding... Kent Fredric
      • Re: ad... Alceu Rodrigues de Freitas Junior via cpan-testers-discuss
        • Re... Jean-Damien Durand
          • ... Alceu Rodrigues de Freitas Junior via cpan-testers-discuss
            • ... Kent Fredric

Reply via email to