On 11/2/07, David Golden <[EMAIL PROTECTED]> wrote:
> On Nov 2, 2007 11:34 AM, Dominique Quatravaux <[EMAIL PROTECTED]> wrote:
> > Sorry I don't do Windows and I have no idea of what's going on here.
> > How can I proceed from there? Is it possible for you to offer some
> > kind of remote access?
>
> I haven't looked much at the external failures yet, but in your
> Build.PL, you need a more portable way of checking Test::Builder.
> (See diff below).  I also saw some test failures where you interpolate
> filenames into like regex without protecting them with quotemeta() --
> which is what you need when you have windows filenames with
> backslashes.
>
> --- Build.PL.old        Fri Nov 02 14:37:09 2007
> +++ Build.PL    Fri Nov 02 14:44:28 2007
> @@ -45,9 +45,10 @@
>  # Fixes an @INC ordering problem dug up by CPAN testers, that causes
>  # Module::Build's version detection algorithm to fail; see
>  # http://www.nntp.perl.org/group/perl.cpan.testers/2007/02/msg422771.html
> +my $quote = $^O eq 'MSWin32' ? q{"} : q{'};
>  if ( (! ($builder->prereq_failures &&
>           $builder->prereq_failures->{requires}->{"Test::Simple"})) &&
> -     (`$^X -MTest::Builder -e 'print "ok" if Test::Builder->can("create");'`
> +     (`$^X -MTest::Builder -e $quote print q{ok} if
> Test::Builder->can(q{create});$quote`
>        !~ m/ok/) ) {
>      die <<"MESSAGE";
>
> David
>

David,
I was looking through my other failed report and I was just about to
say the same thing.  :)

-- 
Matt "Mr. Muskrat" Musgrove

Reply via email to