On Sat, Oct 31, 2009 at 11:53 AM, Barbie <bar...@missbarbell.co.uk> wrote: >> Disallowing underscores in META would be a way to enforce this, but >> then comparing version in META and version in $VERSION is harder. > > Agreed that this needs to be made clear, but I think disallowing > underscores may cause more problems than it's worth.
Disallowing makes it worse. Here's why: $ perl -Mversion -E 'say version->new("1.23_45") <=> version->new("1.2345")' -1 If the first form is specified in an installed *.pm file (as parsed with MM->parse_version), but the second is in the META file, then the META requirement can't be satisfied by the installed file. We *must* allow underscore. The branch I've created is specific in that we only allow a single underscore, though, and for v-strings, only for the last component. > We should make it clear what version formats are acceptable, and in the > event of any possible ambiguity, what will be assumed. Hmm. I don't want to specify what will be assumed or else that becomes defacto acceptable. The likely reality is that what will be assumed is whatever version.pm does. -- David