Re: [PATCH 3/4] check if we have all necessary data

[Denys Vlasenko]

On 03/21/2012 04:10 PM, Vratislav Podzimek wrote:

---
  src/daemon/abrt-server.c |   26 ++++++++++++++++++++++++++
  1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/src/daemon/abrt-server.c b/src/daemon/abrt-server.c
index 41983c8..7ef9ce7 100644
--- a/src/daemon/abrt-server.c
+++ b/src/daemon/abrt-server.c
@@ -287,6 +287,30 @@ static void process_message(GHashTable *problem_info, char 
*message)
      }
  }

+static void die_if_data_is_missing(GHashTable *problem_info)
+{
+    gboolean have_item, missing_data = FALSE;
+    gchar **pstring;
+    static const gchar *const needed[] = {FILENAME_ANALYZER,
+                                          FILENAME_BACKTRACE,
+                                          FILENAME_EXECUTABLE,
+                                          FILENAME_REASON,
+                                          "basename", NULL};
+
+    for (pstring = (gchar**) needed; *pstring; pstring++)
+    {
+        have_item = g_hash_table_lookup(problem_info, *pstring) != NULL;
+        if (!have_item)
+        {
+            error_msg("%s is missing.", *pstring);
+            missing_data = TRUE;
+        }
+    }
+
+    if(missing_data)

Style violation.

+        error_msg_and_die("Some data is missing. Aborting.");
+}
+
  static int perform_http_xact(void)
  {
      /* use free instead of g_free so that we can use xstr* functions from

--
vda