On 07/11/2012 05:54 PM, Jiri Moskovcak wrote:
On 07/11/2012 05:31 PM, Denys Vlasenko wrote:
On 07/11/2012 05:26 PM, Jiri Moskovcak wrote:
Let's add add_text_to_problem_data() to
libreport.1/src/include/problem_data.h
instead of creating yet another abstraction layer.
Abstraction layers are not zero price.
- I don't mind the few microseconds or few bytes it will cost I really
prefer the easy to use API over that...
I'm not so much concerned about overhead but by having
another set of functions which do the same thing.
I am an idiot. I get confused by this stuff.
- ok, so what's the consensus here?
- problem_data_save() definitely belongs to ABRT because it reads the abrt.conf
file
Yes.
- the rest is more or less already in libreport,
> but I would like to see it exported thru some abrt header (which I think
already is)
#include <libreport/problem_data.h>
> and also would like to rename it to problem_data_*
Ok. I will prepare a patch.
- so should we rename the functions in libreport and keep just that one in ABRT?
I think yes, this would be the best solution.
> And what to do with the errors? Like you want to add file which doesn't exist
or have wrong permissions how to propagate that back from functions returning
void?
Adding file *name* of an existing file to problem_data structure does not
guarantee
this file will continue to exist at the time you decide to convert your
problem_data
to a dumpdir... Looks like errors should be checked that this latter stage.
--
vda
