On 07/18/2012 01:01 PM, Jakub Filak wrote: > * introduced run_event_command_on_dir_name() which runs a command, > handles a communication with the command and so on (the code of this > function was originally placed in the run_event_on_dir_name()) > * run_event_on_dir_name() uses the new run_event_command_on_dir_name() > > Signed-off-by: Jakub Filak <[email protected]> > --- > src/lib/run_event.c | 179 > ++++++++++++++++++++++++++------------------------- > 1 file changed, 91 insertions(+), 88 deletions(-) > > diff --git a/src/lib/run_event.c b/src/lib/run_event.c > index 2f9ec92..105cef5 100644 > --- a/src/lib/run_event.c > +++ b/src/lib/run_event.c > @@ -432,6 +432,96 @@ int spawn_next_command(struct run_event_state *state, > return 0; > } > > +static int run_event_command_on_dir_name(struct run_event_state *state, > const char *dump_dir_name)
I think the name can be better. This function doesn't run (as in "start") anything, it just eats output until EOF, then collects exit status. The rest looks ok to me.
