Signed-off-by: Nikola Pajkovsky <[email protected]>
---
src/gtk-helpers/event_config_dialog.c | 5 +++--
src/lib/json.c | 6 +++---
src/lib/make_descr.c | 3 ++-
src/lib/proxies.c | 2 +-
src/plugins/rhbz.c | 6 +++---
src/report-newt/report-newt.c | 2 +-
6 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/gtk-helpers/event_config_dialog.c
b/src/gtk-helpers/event_config_dialog.c
index 190dad1..0125f02 100644
--- a/src/gtk-helpers/event_config_dialog.c
+++ b/src/gtk-helpers/event_config_dialog.c
@@ -355,7 +355,7 @@ int show_event_config_dialog(const char *event_name,
GtkWindow *parent)
/*x,yoptions:*/ GTK_FILL, GTK_FILL,
/*x,ypadding:*/ 0, 0);
const char *store_passwords = get_user_setting("store_passwords");
- if (store_passwords && !strcmp(store_passwords, "no"))
+ if (store_passwords && strcmp(store_passwords, "no") == 0)
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(pass_store_cb), 1);
g_signal_connect(pass_store_cb, "toggled",
G_CALLBACK(on_show_pass_store_cb), NULL);
}
@@ -389,7 +389,8 @@ int show_event_config_dialog(const char *event_name,
GtkWindow *parent)
const char *const store_passwords_s =
get_user_setting("store_passwords");
save_event_config_data_to_user_storage(event_name,
get_event_config(event_name),
- !(store_passwords_s &&
!strcmp(store_passwords_s, "no")));
+ !(store_passwords_s &&
strcmp(store_passwords_s,
+
"no") == 0));
}
//else if (result == GTK_RESPONSE_CANCEL)
// log("log");
diff --git a/src/lib/json.c b/src/lib/json.c
index 2cda77d..e2bfe35 100644
--- a/src/lib/json.c
+++ b/src/lib/json.c
@@ -102,11 +102,11 @@ static void ureport_add_type(struct json_object *ur,
problem_data_t *pd)
if (!pd_item)
return;
- if (!strcmp(pd_item, "CCpp"))
+ if (strcmp(pd_item, "CCpp") == 0)
ureport_add_str(ur, "type", "USERSPACE");
- if (!strcmp(pd_item, "Python"))
+ if (strcmp(pd_item, "Python") == 0)
ureport_add_str(ur, "type", "PYTHON");
- if (!strcmp(pd_item, "Kerneloops"))
+ if (strcmp(pd_item, "Kerneloops") == 0)
ureport_add_str(ur, "type", "KERNELOOPS");
}
diff --git a/src/lib/make_descr.c b/src/lib/make_descr.c
index c8c0f71..585fe4e 100644
--- a/src/lib/make_descr.c
+++ b/src/lib/make_descr.c
@@ -189,7 +189,8 @@ char *make_description(problem_data_t *problem_data, char
**names_to_skip,
if ((item->flags & CD_FLAG_TXT)
&& (strlen(item->content) <= max_text_size
- || (!strcmp(analyzer, "Kerneloops") && !strcmp(key,
FILENAME_BACKTRACE))))
+ || (strcmp(analyzer, "Kerneloops") == 0 && strcmp(key,
+
FILENAME_BACKTRACE) == 0)))
{
char *formatted = problem_item_format(item);
char *output = make_description_item_multiline(key, formatted
? formatted : item->content);
diff --git a/src/lib/proxies.c b/src/lib/proxies.c
index b52be91..10b11c0 100644
--- a/src/lib/proxies.c
+++ b/src/lib/proxies.c
@@ -48,7 +48,7 @@ GList *get_proxy_list(const char *url)
free(proxies);
/* Don't set proxy if the list contains just "direct://" */
- if (l && !g_list_next(l) && !strcmp(l->data, "direct://"))
+ if (l && !g_list_next(l) && strcmp(l->data, "direct://") == 0)
{
list_free_with_free(l);
l = NULL;
diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c
index 905660b..d65ce65 100644
--- a/src/plugins/rhbz.c
+++ b/src/plugins/rhbz.c
@@ -192,7 +192,7 @@ int is_comment_dup(GList *comments, const char *comment)
{
const char * const comment_body = (const char *) l->data;
char * const trim_comment_body = trim_all_whitespace(comment_body);
- same_comments = !strcmp(trim_comment_body, trim_comment);
+ same_comments = strcmp(trim_comment_body, trim_comment) == 0;
free(trim_comment_body);
}
@@ -836,7 +836,7 @@ int rhbz_attach_files(struct abrt_xmlrpc *ax, const char
*bug_id,
const char *analyzer = problem_data_get_content_or_NULL(problem_data,
FILENAME_ANALYZER);
/* Do not attach anything if analyzer is Kerneloops */
- if (!strcmp(analyzer, "Kerneloops"))
+ if (strcmp(analyzer, "Kerneloops") == 0)
return 0;
GHashTableIter iter;
@@ -858,7 +858,7 @@ int rhbz_attach_files(struct abrt_xmlrpc *ax, const char
*bug_id,
const unsigned len = strlen(content);
/* For standard bugs, do not attach backtrace shorter than
CD_TEXT_ATT_SIZE_BZ */
- if (!strcmp(name, FILENAME_BACKTRACE) && len < CD_TEXT_ATT_SIZE_BZ)
+ if (strcmp(name, FILENAME_BACKTRACE) == 0 && len <
CD_TEXT_ATT_SIZE_BZ)
continue;
rhbz_attach_blob(ax, name, bug_id, content, len, flags);
diff --git a/src/report-newt/report-newt.c b/src/report-newt/report-newt.c
index 6287445..318ff10 100644
--- a/src/report-newt/report-newt.c
+++ b/src/report-newt/report-newt.c
@@ -128,7 +128,7 @@ static int configure_reporter(struct reporter *r, bool
skip_if_valid)
break;
case OPTION_TYPE_BOOL:
options[i] = newtCheckbox(0, 0, "", opt->eo_value &&
- !strcmp(opt->eo_value, "yes") ? '*' : ' ', NULL,
NULL);
+ strcmp(opt->eo_value, "yes") == 0 ? '*' : ' ',
NULL, NULL);
break;
default: /* TODO? */
options[i] = NULL;
--
1.7.10.2
