Looks good to me. Just one comment about coding style :)
On Tuesday 22 of January 2013 15:21:41 Jiri Moskovcak wrote:
> ---
> src/lib/problem_data.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/problem_data.c b/src/lib/problem_data.c
> index 724a702..6618ae2 100644
> --- a/src/lib/problem_data.c
> +++ b/src/lib/problem_data.c
> @@ -60,12 +60,19 @@ problem_data_t *problem_data_new(void)
> void problem_data_add_basics(problem_data_t *pd)
> {
> const char *analyzer = problem_data_get_content_or_NULL(pd,
> FILENAME_ANALYZER);
> + const char *type = problem_data_get_content_or_NULL(pd, FILENAME_TYPE);
> if (analyzer == NULL)
> {
> analyzer = "libreport";
> +
> + if (type)
> + analyzer = type;
> +
Please, keep conditions style consistent.
Either
if (type != NULL)
or
analyzer = type != NULL ? type : "libreport";
> problem_data_add_text_noteditable(pd, FILENAME_ANALYZER, analyzer);
> }
> - problem_data_add_text_noteditable(pd, FILENAME_TYPE, analyzer);
> +
> + if (type == NULL)
> + problem_data_add_text_noteditable(pd, FILENAME_TYPE, analyzer);
>
> /* If application didn't provide dupe hash, we generate it
> * from all components, so we at least eliminate the exact same
>
