* Dave Anderson [2009-01-14 16:17]:
>
> (1) Your patch would only work with 32-bit ELF kdumps since the
> vmcoreinfo_read_integer()
> function is only called by dump_Elf32_Nhdr() -- and not by
> dump_Elf64_Nhdr().
> I wouldn't think that ppc64 and ia64 could even create 32-bit ELF kdumps
> since
> they would by definition have to truncate certain fields? I presume you
> either
> forgot the 64-bit part of the patch, or maybe incorrectly put the code in
> the
> wrong function?
Yes, that was an error while copying over the code to create the patch.
> (2) Even so, in the dump_Elf32_Nhdr() switch statement, you're taking over the
> "0" case, whereas it used to be picked up by the "default" case -- which
> currently dumps the vmcoreinfo data. Now that code can never be run, and
> I don't want to give up that capability.
Fixed.
> (3) I think I'd like to keep it forcibly segregated to ia64 and ppc64,
> instead of
> letting the other architectures even call
> vmcoreinfo_read_integer(PAGESIZE).
> I don't want to even allow a *remote* possibility of breaking things on
> the
> other arches.
Done.
> (4) vmcore_info_read_integer() shouldn't be called if the "store" paramter
> isn't set.
Done.
> (5) Minor nit -- I'd just as soon leave any changes to ia64_init_hyper() to
> its
> maintainer, especially since it makes no sense to make a follow-up call to
> ia64_check_adjust_pagesize().
Done.
Bernhard
--
Bernhard Walle, SUSE Linux Products GmbH, Architecture Development
--
Crash-utility mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/crash-utility
