Hi Dave,

On Fri, 20 Apr 2012 10:03:23 -0400 (EDT)
Dave Anderson <[email protected]> wrote:

> > Sounds good. So what about introducing a new macro LIVE() that
> > indicates that the dump or live system is inconsistent.
> 
> Good idea -- queued for crash-6.0.6.

There is another ACTIVE() call in s390x.c that should be changed to
LIVE(). When issuing "bt" on a running task on a live system, we
currently write "(active)".

This should also be done for live dumps:
---
 s390x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/s390x.c
+++ b/s390x.c
@@ -1092,7 +1092,7 @@ static void s390x_back_trace_cmd(struct 
         * Print lowcore and print interrupt stacks when task has cpu
         */
        if (s390x_has_cpu(bt)) {
-               if (ACTIVE()) {
+               if (LIVE()) {
                        fprintf(fp,"(active)\n");
                        return;
                }

---
 s390x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/s390x.c
+++ b/s390x.c
@@ -1092,7 +1092,7 @@ static void s390x_back_trace_cmd(struct 
 	 * Print lowcore and print interrupt stacks when task has cpu
 	 */
 	if (s390x_has_cpu(bt)) {
-		if (ACTIVE()) {
+		if (LIVE()) {
 			fprintf(fp,"(active)\n");
 			return;
 		}
--
Crash-utility mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/crash-utility

Reply via email to