----- Original Message -----
> This series decreases crash startup and 'ps' processing time when handling 
> dumps
> with many tasks.  Prior to the series a 1M task dump took 45m to load and 45m
> more to run ps.  Once patched, startup+ps time drops below 40 seconds.

Hi Greg,

This sounds really good, although I have to say I've never encountered a 
dumpfile
that had such a large task count.  I will review and test the patch-set next 
week.

BTW, did you test this on a live system that has such a large task count? 
Like for example, as I recall, the task_exists() checks that you removed are
checking for tasks that were found when scanning the lists, but gone by the
time it got around to storing them. 

Thanks,
  Dave

> 
> Greg Thelen (4):
>   refactor store_context => add_context
>   refactor task_to_pid
>   remove unreachable (and slow) code
>   index task_context by task
> 
>  defs.h |   2 +
>  task.c | 191 +++++++++++++++++++++++++++------------------------------
>  2 files changed, 92 insertions(+), 101 deletions(-)
> 
> --
> 2.17.0.484.g0c8726318c-goog
> 
> --
> Crash-utility mailing list
> Crash-utility@redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
> 

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility

Reply via email to