On Tue, Apr 17, 2018 at 4:15 PM, Dave Anderson <ander...@redhat.com> wrote: > > ----- Original Message ----- >> Daniel Vacek (3): >> tree: no need to bail out on tree corruption >> tree: add an option to dump the tree sorted >> tree: document that type defaults to rbtree >> >> defs.h | 1 + >> help.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- >> tools.c | 51 ++++++++++++++++++++++++++++++++++++++------------- >> 3 files changed, 97 insertions(+), 15 deletions(-) >> > > Hi Daniel, > > This looks good. I fixed up the "make warn" issues for tools.c, and moved > the new rbtree help page info up into the rbtree section. Queued for > crash-7.2.2: > > > https://github.com/crash-utility/crash/commit/90642e6ffa32aaa5aacd24871c81592afd05f6a2
Checking it I just realized that the help does not state that '-l' option actually only applies to redblack trees and the code also does not check and report misuse when '-l' is specified together with '-t ra'. --nX > Thanks, > Dave -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility
