Thanks for updating the page. I amended the fix to use a separate option: https://github.com/crash-utility/crash/pull/86/commits/308e279a71b1a815121a48d65f98db4886f5dcbf
On Thu, Jun 10, 2021 at 8:20 PM HAGIO KAZUHITO(萩尾 一仁) <[email protected]> wrote: > Hi Luc, > > -----Original Message----- > > When you can. > > (let me know if I need to go through a different channel for these > changes) > > > > > > 1. Updates to the extension page ( > https://crash-utility.github.io/extensions.html) > > > > * change email associated with eppic extension from > > > > * [email protected] <mailto:[email protected]> > > > > * to: > > > > * [email protected] <mailto:[email protected]> > > > > * change eppic code pointer from : > > > > * http://code.google.com/p/eppic > > > > * to: > > > > * https://github.com/lucchouina/eppic > > Updated. > > https://github.com/crash-utility/crash-utility.github.io/commit/9eb28df822853201c09c77ae2cd140ffcf47bfd1 > > If there is error/lack of fix, please let me know. > > > > > 2. A (tiny) pull request > > I know email patches are preferred, but this is a trivial > (one-liner) change for the Eppic extension > > build handling. > > https://github.com/crash-utility/crash/pull/86 > > > > OK, the main reason why email patches are preferred is to make the patches > and discussion open to more watchers here. In that sense, you sent this > email, it almost meets the purpose. > > And, I thought that introducing something like $(EPPIC_GIT_OPTION) may be > also good, but I'm ok with either. > > Acked-by: Kazuhito Hagio <[email protected]> > > Thanks, > Kazu > > > > -- > Crash-utility mailing list > [email protected] > https://listman.redhat.com/mailman/listinfo/crash-utility > > -- - Luc
-- Crash-utility mailing list [email protected] https://listman.redhat.com/mailman/listinfo/crash-utility
