On Thu, Mar 23, 2023 at 8:30 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio...@nec.com>
wrote:

> It's fine to check here, but shall we say why it's wrong?


Sure. I will add it to the patch log, and post v2 later.



I'd prefer something like this.
>
> if (!IS_KVADDR(pc->curcmd_private))
>          error(FATAL, "invalid mm_struct address: %s\n", optarg);
>
>
Also fine to me.

Thanks.
Lianbo
--
Crash-utility mailing list
Crash-utility@redhat.com
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki

Reply via email to