On Mon, Dec 27, 2010 at 02:14:05AM +0000, jpeg wrote:
> commit 2ea14a83b7d2f9f57106f5ccf2b24ee9caadca85
> 
>     Silence a compilation warning.

> --- a/crawl-ref/source/mon-util.cc
> +++ b/crawl-ref/source/mon-util.cc
> @@ -4368,6 +4368,7 @@ actor *find_agent(mid_t m, kill_category kc)
>          // currently hostile dead/gone monsters are no different from env
>          return 0;
>      case KC_NCATEGORIES:
> +    default:
>          ASSERT(false);
>          return 0;
>      }

Just curious... what compiler emits a warning there?  It'd be totally
unwarranted -- all enum values including that extraneous KC_NCATEGORIES are
handled, so I wonder what's wrong.

I checked old gcc (4.4), new gcc (4.5), clang (svn 121132) and mingw (4.4),
and none of these shows anything for that file.

-- 
1KB             // Microsoft corollary to Hanlon's razor:
                //      Never attribute to stupidity what can be
                //      adequately explained by malice.

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Crawl-ref-discuss mailing list
Crawl-ref-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/crawl-ref-discuss

Reply via email to