Review: Needs Fixing

Thanks! Here are my comments,

- The analytic sequences are not new but come from the account module, and need 
to be renamed here because analytic is a dependency of account.
- 'type' is now required. You may want to replace empty values in the database 
with the new default 'normal' just to be sure.
- 'manager_id' is set by an onchange method to the partner's salesperson 
('user_id'). It would be nice if you could retrieve and store this value for 
all existing analytic accounts that have a partner_id (in the post script).

Keep up the great work, Sylvain!



-- 
https://code.launchpad.net/~sylvain-legal/openupgrade-addons/migration-analytic/+merge/174751
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.

-- 
Mailing list: https://launchpad.net/~credativ
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~credativ
More help   : https://help.launchpad.net/ListHelp

Reply via email to