Review: Needs Fixing

I maintain that migrating a workflow transition to another module is a bad idea 
if the target module is not a logical dependency of the source module like in 
this case (See 
https://code.launchpad.net/~sylvain-legal/openupgrade-addons/7.0-procurement/+merge/184206/comments/438183).
 Any arguments against that? Otherwise, most of the contents from the 
pre-script could be removed.

Maybe you have noticed that a script was added to the server distribution 
recently that attempts to extract the changes in noupdate data. You can run it 
as follows:

python /path-to/openupgrade-server-7.0/scripts/compare_noupdate_xml_records.py 
/path/to/openobject-addons-6.1/procurement 
/path/to/openobject-addons-7.0/procurement

The output is an XML file with the changes, that you can review and load from 
the post script. It will tell you in this case that the arguments of the 
procurement scheduler cron job have changed to force the scheduler to open its 
own database cursor that commits each procurement atomically. It seems like a 
good idea to include this data in the migration of this module.

-- 
https://code.launchpad.net/~sylvain-legal/openupgrade-addons/7.0-mrp/+merge/186298
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.

-- 
Mailing list: https://launchpad.net/~credativ
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~credativ
More help   : https://help.launchpad.net/ListHelp

Reply via email to