Review: Needs Fixing code review 10ff: You need to check if this option exists (has_option) before accessing it, as also SafeConfigParser raises ConfigParser.NoOptionError on nonexisting options. Then you can remove 12f
Could you explain why you do the extra checks and unset PGPASSWORD? The environment you change will die with the script process, and the only other processes who see it are the openupgrade servers it starts, or am I mistaken? -- https://code.launchpad.net/~therp-nl/openupgrade-server/7.0_lp1265463_use_password/+merge/200301 Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-server. -- Mailing list: https://launchpad.net/~credativ Post to : [email protected] Unsubscribe : https://launchpad.net/~credativ More help : https://help.launchpad.net/ListHelp
