Review: Needs Information code review, no test.

Just one thing. If you do not manage the case of the xml_id 
"dir_partner_category", the document.directory will be deleted ?
Why do you guess that this object is unused ?

What about to do in a pre-migration script a request like the following, to 
make the object persistent ?

delete * from ir_model_data where module ='document' and name 
='dir_partner_category';

Otherwise, all looks good to me.
-- 
https://code.launchpad.net/~akretion-team/openupgrade-addons/61-to-70-document/+merge/221970
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.

-- 
Mailing list: https://launchpad.net/~credativ
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~credativ
More help   : https://help.launchpad.net/ListHelp

Reply via email to