My opinion is it would be nice to fix at some point when you're cleaning stuff up, Yang.

I'm not an active C++ programmer so I don't notice this kind of thing...

John


On 10/2/12 8:34 AM, Konstantin Tokarev wrote:


02.10.2012, 18:29, "Eric Eide" <[email protected]>:
"Konstantin" == Konstantin Tokarev <[email protected]> writes:

         Konstantin> I see that clang_delta extensively uses (void) argument in
         Konstantin> C++ functions. I think it's not traditional for C++ code
         Konstantin> and should be replaced with empty argument list.
         Konstantin>
         Konstantin> Is this change welcome, or it's project-specific coding
         Konstantin> style?

I'd suggest not changing this unless it is actually causing a problem.

OK.


Is it causing a problem?  A warning from some compiler, perhaps?

No, just bad style (IMO).

Reply via email to