My reason for submitting multiple was "I was unaware I could make a change and push it to the same gerrit ID". I use commandline git, and hadn't seen that workflow option before.
Thanks for the idea -- it'll definitely reduce the gerrit clutter and the need to resubmit/abandon so many gerrits. :D On Fri, Feb 23, 2018 at 4:45 AM, Frederic Gurr < [email protected]> wrote: > Hi, > > As a side note: I noticed that you created multiple Gerrit reviews and > abandoned each one. If you "amend" your Git commits instead, you can add > multiple patch sets to a single Gerrit review. AFAIK that's closer to > the usual Gerrit workflow. > > You might have a perfectly fine reason for doing things differently. > Please ignore my comment then. ;) > > > Regards, > > Fred > > > -- > Frederic Gurr > > Release Engineer > Eclipse Foundation > > On 22.02.2018 18:44, Nick Boldt wrote: > > After several failed attempts to make changes to the dtp.aggrcon file, > > which caused the gerrit build to fail, I submitted this no-op change, > > which simply adds a space to the end of a line. > > > > https://git.eclipse.org/r/#/c/117970/1/dtp.aggrcon > > > > The gerrit job failed: > > > > https://ci.eclipse.org/simrel/job/simrel.photon. > runaggregator.VALIDATE.gerrit/196/ > > > > Can someone with more knowledge about how to actually build these files > > take a look and retrigger the change, so we can get green balls for > > aggregator validation builds again? I would but the magic underlying b3 > > aggregation is a black box to me. :( > > > > Thanks! > > > > > > -- > > > > Nick Boldt > > > > Senior Software Engineer, RHCSA > > > > Productization Lead :: JBoss Tools & Dev Studio > > > > IM: @nickboldt / @nboldt / http://nick.divbyzero.com > > > > <https://red.ht/sig> > > TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> > > > > @ @redhatnews <https://twitter.com/redhatnews> Red Hat > > <https://www.facebook.com/RedHatInc> > > <https://www.facebook.com/RedHatInc> > > > > > > “The Only Thing That Is Constant Is Change” - Heraclitus > > > > > > _______________________________________________ > > cross-project-issues-dev mailing list > > [email protected] > > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev > > > _______________________________________________ > cross-project-issues-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev > -- Nick Boldt Senior Software Engineer, RHCSA Productization Lead :: JBoss Tools & Dev Studio IM: @nickboldt / @nboldt / http://nick.divbyzero.com <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> @ @redhatnews <https://twitter.com/redhatnews> Red Hat <https://www.facebook.com/RedHatInc> <https://www.facebook.com/RedHatInc> “The Only Thing That Is Constant Is Change” - Heraclitus
_______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
