Well, originally I did just edit the *aggrcon file, but of course being
an EMF expert I immediately noticed it was a cross reference so it
seemed obvious (to me) that I needed to add a Contact. And because I
couldn't find my name "Ed Merks", I did just add a new Contact. Then I
was a bad boy and didn't invoke Validate from the menu in order to
notice up front that I introduced the key conflict on the email address;
EMF generates nice Live Validation support that could be used in this
editor so that users always get feedback even if they don't Validate...
And then the build log was so fully of noise, I didn't see the important
part I was supposed to see, but rather exit code 13. Silly me. But all
is good now. Note that there are no unfortunate eOpposites involved in
this case, i.e., contacts don't have serialized references to the
*.aggrcon files that reference them.
On 08.03.2018 17:09, Ed Willink wrote:
Hi Ed
The duplicate [email protected] is indeed the problem because it is
the no longer unique target for an eOpposite.
I suspect that you got caught out like most happy XML hackers by
thinking that you could do a trivial edit locally. Non-trivial edits
must be done while editing simrel.aggr. The quick validate build was
added to get fast detection of a broken simrel.aggr.
The simrel.aggr + *.aggrcon structure is a good design in that each
project is substantially independent but unfortunately a bad design in
that there are many fragile eOpposites that break if a project file
evolves non-trivially.
I suspect that the simrel.aggr references could all be unidirectional
from *.aggrcon to simrel.aggr and the fragility would go. The
simrel.aggr to *.aggrcon references should be no more than a contents
list of top level elements.
Regards
Ed Willink
On 08/03/2018 15:52, Ed Merks wrote:
Thanks Nick and Arthur for the timely help! I was able to fix the
problem by removing the "EMFT Ecore Tools Build Team" contact and the
reference to it from emft-ecoretools.aggrcon. Who knew that was a
Team?! :-P
I cleaned up the .mailmap file too, whatever that thing is for...
On 08.03.2018 16:43, Nick Boldt wrote:
It could be because the simrel.aggr file with your PR contains your
email address TWICE - first on line 538, and again as added on 659.
I imagine the model might expect every person/email address is
unique, even if they're attached to multiple projects.
Nick
On Thu, Mar 8, 2018 at 10:28 AM, Arthur van Dorp
<[email protected]
<mailto:[email protected]>> wrote:
Hi Ed,
It does seem to be unhappy about the mail address changes:
Build failed! Exception was
org.eclipse.core.runtime.CoreException: Aggregation model is
inconsistent:
The feature 'contacts' has key [email='[email protected]
<mailto:[email protected]>'] for
'org.eclipse.cbi.p2repo.aggregator.impl.ContactImpl@4aeaadc1{file:/home/hudson/genie.simrel/.jenkins/jobs/simrel.photon.runaggregator.VALIDATE.gerrit/workspace/org.eclipse.simrel.build/simrel.aggr#//@contacts[email='[email protected]
<mailto:[email protected]>']}' which collides with that of
'org.eclipse.cbi.p2repo.aggregator.impl.ContactImpl@7daa61f3{file:/home/hudson/genie.simrel/.jenkins/jobs/simrel.photon.runaggregator.VALIDATE.gerrit/workspace/org.eclipse.simrel.build/simrel.aggr#//@contacts[email='[email protected]
<mailto:[email protected]>']}'
Regards,
Arthur
*Von:*[email protected]
<mailto:[email protected]>
[mailto:[email protected]
<mailto:[email protected]>] *Im
Auftrag von *Ed Merks
*Gesendet:* Donnerstag, 8. März 2018 16:23
*An:* Cross project issues
*Betreff:* [cross-project-issues-dev] Simrel Build Failing
Hi,
My attempt to contribute
http://download.eclipse.org/modeling/emf/emf/builds/milestone/S201803080939/
<http://download.eclipse.org/modeling/emf/emf/builds/milestone/S201803080939/>
for M6 via https://git.eclipse.org/r/#/c/119008/
<https://git.eclipse.org/r/#/c/119008/> failed, but the log line
suggests that perhaps the launch simply failed rather than there
being some actual verification failure:
[exec] Result: 13
What should I do?
Regards,
Ed
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
<mailto:[email protected]>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
<https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev>
--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
@ @redhatnews <https://twitter.com/redhatnews> Red Hat
<https://www.facebook.com/RedHatInc>
<https://www.facebook.com/RedHatInc>
“The Only Thing That Is Constant Is Change” - Heraclitus
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
Virus-free. www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
