On Thu, 2009-01-08 at 08:03 -0500, James Carlson wrote: > Sebastien Roy writes: > > > > On Thu, 2009-01-08 at 07:23 -0500, James Carlson wrote: > > > Technically, PPP links have an L2 address length of exactly zero. > > > > > > But I can't say I was expecting the MAC layer to support anything > > > other than Ethernet for quite some time. > > > > I was, since the MAC layer supported MACs with arbitrary MAC lengths > > (including 0) prior to build 105. I did a significant amount of work a > > few years back to make sure that all (or at least most, since VLANs were > > still a wart in dls) references to Ethernet and MAC address lengths and > > other MAC-type-specific concepts were removed from the framework and > > placed into the plugin modules. > > OK ... it was the VLAN and aggr references (some of which seem to run > pretty deep) that had me convinced that MAC wouldn't be ready for PPP > for a while.
Supporting PPP in GLDv3 (before build 105) would have simply required writing a PPP MAC-type plugin. The hard work or porting PPP to GLDv3 is in the sppp module and pppd daemon. The GLDv3 framework was basically ready for it. Aside from this seemingly unnecessary address length constraint, there appears to be new constraints on what SAP values look like in mac_flow.c. I'll start another discussion on this topic when I run into this once I'm further along with my Crossbow merge. -Seb
