On Wed, 2009-08-12 at 11:29 -0700, Peter Memishian wrote: > > General: There are quite a bit of changes related to the style of > > local variable declaration that was changed, thus adding to the volume > > of the review. In general, it would be preferable to restrict the set > > of changes to the functionality being added, and to cstyle and lint > > issues found while making these changes. Otherwise, sticking with the > > existing style of the file without making sweeping changes to style > > based on personal preference should be the modus operandi. I won't > > comment on each instance, I've restricted my specific comments to > > things not related to local variable declarations. :-) > > I'd go a step further and demand that all changes that are related to > separating initializers from declarations be reverted.
Yes, I would also include such modifications in the category of style changes that I wish to be reverted. -Seb
