Hi Roamer and all,

Here is my comments[resent from our internal aliases to sync with people 
here :-) ]
After a long digging into this document,  for me, it  is a very decent  
document. And I have a few questions according to this document( maybe 
related, maybe not :-) , but I ask help from your expertise on this).
1. Multiple Interrupts Support:  When the device driver is capable of 
MSI-X, *how about MSI?*
2. For DRR and DRRG, is there any parameter to record this in your ring 
structure?
3. Is it possible that remove/add ring group functions were  required? 
Especially for TX ring group,  if some error happenes on one ring (or 
group), may I remove it dynamically?
For group, I think mr_rem_ring is not enough. Is the mrg_stop used for 
this purpose?
*4. *The administrator may choose to maximize the number of groups, in 
order to increase the number of virtual NICs that can be built over this 
NIC.**
If a NIC  only has 1 rx ring and 1 tx ring, does it mean that only one 
VNIC can be built over this NIC? Or I can simply increase the number of 
groups to increase the number of VNICs but every VNIC share the only  1 
rx/tx ring?

5. Does it need to add status bit into 
mac_rx_ring_info_t/mac_rx_ring_group_info_t/mac_tx_ring_info_t structures?

6. For this document is about hardware resources, but I can not see any 
words about hardware checksum. Will you merge the rings capability into 
m_getcapab or add another item into mac_callbacks_t?

7. For VNIC is introduced by Crossbow. Is it possible that we can use a 
uniform name for all the NICs drivers when doing  the configuration(, 
such as ifconfig vnic0 plumb up)? Maybe it is related to Brussel. :-)

Thanks,
Jason
Yunsong (Roamer) Lu ??:
> Hi,
> We've posted a new design document, Crossbow Hardware Resources 
> Management and Virtualization, here:
> http://dlc.sun.com/osol/netvirt/downloads/docs/virtual_resources.pdf
> you're welcome to review and comment.
>
> In this document, we introduce the new driver interfaces of virtualizing 
> NIC resources, like multiple rings and multiple MAC addresses, and we 
> talk about the ideas about organizing various hardware implementations 
> into the new framework. We're glad to know any comments from IHVs who 
> are designing new NICs.
>
> What's not included in the document? The new design evolves GLDv3 
> interfaces, but before finalizing those changed interfaces, like 
> (*mc_tx)(), (*mc_unicast)(), (*mc_resoureces)(), mac_rx(), etc., we 
> would like to listen to your opinions first. Also, support for PCI-SIG 
> IOV will be added afterwards.
>
> Please feel free to comment and share your opinions!
>
> Thanks,
>
> Kais & Roamer
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/crossbow-discuss/attachments/20071012/4f582eee/attachment.html>
  • [crossbow-disc... Yunsong (Roamer) Lu
    • [crossbow... Paul Durrant
    • [crossbow... Jason Jiang - Solaris China Team
    • [crossbow... Yunsong (Roamer) Lu
      • [cros... Kais Belgaied
      • [cros... deepti dhokte - Sun Microsystems - Menlo Park United States
        • [... Yunsong (Roamer) Lu
          • ... deepti dhokte - Sun Microsystems - Menlo Park United States
            • ... Yunsong (Roamer) Lu
              • ... deepti dhokte - Sun Microsystems - Menlo Park United States
                • ... Yunsong (Roamer) Lu
                • ... deepti dhokte - Sun Microsystems - Menlo Park United States

Reply via email to