Thanks for the comments. Responses below. The updated webrev will be made available.
-venu >I've reviewed the change for e1000g, igb, ixgbe, bge, rge, nge, xge: > >e1000g_main.c: >line 79: Too many blank / tab? > ACCEPT >rge_rxtx.c: >line 292: Should it be HCK_IPV4_HDRCKSUM_OK? > REJECT - It was not before. Is there an existing bug? >Please be notified that igb Brussels support has been integrated into >snv today. ixgbe LRO support has be integrated into snv yesterday. So >you'll need to modify the related code for the new change. > Thanks for the heads-up. > On 2009-12-25 16:54, Eric Cheng wrote: >> Hi, folks >> >> We'd like to make the code available for review for the following >> additions as part of follow-up to the crossbow project: >> >> PSARC/2009/638 Public GLDv3 Interfaces >> PSARC/2009/501 Dynamic Ring Grouping on NICs >> PSARC/2009/448 pool dladm link property >> PSARC/2009/436 Anti-spoofing Link Protection >> PSARC/2009/364 dlstat and flowstat >> >> Webrev: http://cr.opensolaris.org/~tlc/crossbow_onnv130 >> >> The changes also include some bug fixes. The changes/webrev is based on >> build 130. We will update the webrev once in a couple of weeks time to >> include some minor bug fixes, however we'd like to get started on the >> code review now. >> >> Thanks in advance, to Sebastien, Cathy, Girish and Garrett who have >> agreed to review the changes. >> >> Please send comments etc. to crossbow-discuss at opensolaris.org by >> the 15th of Jan. If anyone needs more time, please let us know. >> >> For internal folks, the webrev is @ >> /net/nvtbld-x.sfbay/exportz/crossbow/crossbow_onnv130/webrev >> /net/nvtbld-x.sfbay/exportz/crossbow/crossbow_onnv130/webrev-closed >> The above also has cscope built. >> >> Thanks, and seasons greetings from the crossbow team. >> >> _______________________________________________ >> crossbow-discuss mailing list >> crossbow-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/crossbow-discuss > _______________________________________________ > crossbow-discuss mailing list > crossbow-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/crossbow-discuss >
