"Menard, Alexis" <[email protected]> writes:

>> - Should the commit messages have a specific format (for pull request
>>  #763, for example, I used `git cherry-pick -x` to have the original
>>  commit's hash in the commit message)? How about the pull requests
>>  themselves?
>> - How long are we supposed to wait before sending backport PRs?
>
> I think it should happen ASAP IMHO. We'll have buildbots and the beta
> branch and maybe on the stable to find bad things.
>
> Ideally we should have a tool that cherry pick automatically.
>
> We need to be VERY careful with the cherry pick and be very strict on
> potential problems.
>
> Fortunately we have QA rounds on beta and stable channel if needed but
> we really need to be careful.

I would like to wait for at least the build bots to cycle and build the
commit in master before cherry-picking.

Plus, I'm a bit worried about not filing pull requests with
cherry-picks, not only because it is more likely fewer people will be
aware of what's being cherry-picked, but also because people may screw
up with commit message styles and things like that too.

When you mention being strict, do you have anything in mind? I would
like to agree on a few bullet points, send those in an email and add it
to the website.
_______________________________________________
Crosswalk-dev mailing list
[email protected]
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Reply via email to